Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pre-empty-case situation #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve pre-empty-case situation #78

wants to merge 1 commit into from

Conversation

treeowl
Copy link
Contributor

@treeowl treeowl commented Sep 30, 2021

  • Move all the empty case CPP crud into its own module. We just
    need to define a single absurd1 :: V1 a -> b function.

  • Use pseq to guarantee that the compat code will actually
    produce the correct bottom.

@treeowl
Improve pre-empty-case situation
bb3fe2f 
* Move all the empty case CPP crud into its own module. We just
  need to define a single `absurd1 :: V1 a -> b` function.

* Use `pseq` to guarantee that the compat code will actually
  produce the *correct* bottom.
@RyanGlScott
Copy link
Collaborator

Thanks! There's one build failure on GHC 7.0:

[ 5 of 23] Compiling Generics.Deriving.Absurd ( src/Generics/Deriving/Absurd.hs, /__w/generic-deriving/generic-deriving/dist-newstyle/build/x86_64-linux/ghc-7.0.4/generic-deriving-1.14.1/build/Generics/Deriving/Absurd.o )

src/Generics/Deriving/Absurd.hs:11:12:
    Not in scope: type constructor or class `V1'

This can likely be fixed by importing from Generics.Deriving.Base instead of GHC.Generics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treeowl @RyanGlScott